-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(FullscreenModal): add component #22
Conversation
9a59804
to
59de993
Compare
ef0036d
to
e5623dd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but one last thing to consider
2395281
to
466876d
Compare
466876d
to
cea34fb
Compare
cea34fb
to
29f3d31
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, wish it could go without all the ref passing and complex observers but I don't have any better solution to offer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
367d8ab
to
a671f8c
Compare
🎉 This PR is included in version 1.0.0-alpha.15 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This PR is adding a component for FullscreenModal pattern.
Supported layouts
single-6
- single column layout (total width of 6 columns)single-8
- single column layout (total width of 8 columns)sidebar-4-6
- two columns layout (total width of 10 columns, 4 for sidebar and 6 for content)sidebar-4-8
- two columns layout (total width of 12 columns, 4 for sidebar and 8 for content)Usage