Skip to content

Commit

Permalink
feat(Heading): remove H0
Browse files Browse the repository at this point in the history
  • Loading branch information
Mnau-mnau committed Oct 3, 2023
1 parent 00eb53a commit f72f2ef
Show file tree
Hide file tree
Showing 7 changed files with 11 additions and 43 deletions.
1 change: 0 additions & 1 deletion src/components/typographyLegacy/Heading/Heading.enums.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
export const HeadingSizes = {
h0: 'h0',
h1: 'h1',
h2: 'h2',
h3: 'h3',
Expand Down
10 changes: 1 addition & 9 deletions src/components/typographyLegacy/Heading/Heading.stories.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import React from 'react';
import { Meta, Story } from '@storybook/react/types-6-0';

import Heading, { H0, H1, H2, H3, H4, H5 } from './Heading';
import Heading, { H1, H2, H3, H4, H5 } from './Heading';
import { HeadingProps } from './Heading.types';
import { HeadingSizes, HeadingVariants } from './Heading.enums';
import { generateControl } from '../../../utils/tests/storybook';
Expand Down Expand Up @@ -37,14 +37,6 @@ Playground.parameters = {
screenshot: { skip: true },
};

export const H0Story: Story = () => (
<>
<H0>Heading H0</H0>
<H0 variant={HeadingVariants.secondary}>Heading H0 - secondary</H0>
</>
);
H0Story.storyName = 'Heading H0';

export const H1Story: Story = () => (
<>
<H1>Heading H1</H1>
Expand Down
18 changes: 0 additions & 18 deletions src/components/typographyLegacy/Heading/Heading.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -39,11 +39,6 @@ const HeadingBase = css<HeadingProps>`
${({ variant }) => variants[variant]};
`;

const HeadingH0 = styled.h1`
${HeadingBase};
font-size: ${getFontSize('h0')};
line-height: normal;
`;
const HeadingH1 = styled.h1`
${HeadingBase};
font-size: ${getFontSize('h1')};
Expand Down Expand Up @@ -74,7 +69,6 @@ const HeadingH5 = styled.h5`
`;

const headingSizes = {
h0: HeadingH0,
h1: HeadingH1,
h2: HeadingH2,
h3: HeadingH3,
Expand Down Expand Up @@ -109,18 +103,6 @@ Heading.propTypes = {

export default Heading;

export const H0: React.FC<
Omit<React.ComponentProps<typeof Heading>, 'size'>
> = ({ children, ...props }) => (
<Heading size={HeadingSizes.h0} {...props}>
{children}
</Heading>
);

H0.propTypes = {
variant: PropTypes.oneOf(Object.values(HeadingVariants)),
};

export const H1: React.FC<
Omit<React.ComponentProps<typeof Heading>, 'size'>
> = ({ children, ...props }) => (
Expand Down
2 changes: 1 addition & 1 deletion src/components/typographyLegacy/Heading/index.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
export * as HeadingEnums from './Heading.enums';
export { default as Heading, H0, H1, H2, H3, H4, H5 } from './Heading';
export { default as Heading, H1, H2, H3, H4, H5 } from './Heading';
export * from './Heading.types';
17 changes: 9 additions & 8 deletions src/theme/typography.stories.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -95,16 +95,9 @@ and is bundled within this package.

## Font sizes

### Hedings
### Headings

<FontPalette>
<FontItem
title="theme.typography.size.h0"
subtitle="Document header and other special cases"
sampleText="Heading H0"
fontSize={theme.typography.size.h0}
fontWeight={theme.typography.weight.medium}
/>
<FontItem
title="theme.typography.size.h1"
subtitle="Page-level headers"
Expand Down Expand Up @@ -137,6 +130,14 @@ and is bundled within this package.
fontWeight={theme.typography.weight.medium}
lineHeight={theme.typography.lineHeight.lg}
/>
<FontItem
title="theme.typography.size.h5"
subtitle="Block headers"
sampleText="Heading H5"
fontSize={theme.typography.size.h5}
fontWeight={theme.typography.weight.medium}
lineHeight={theme.typography.lineHeight.mdPlus}
/>
</FontPalette>

### Body text
Expand Down
5 changes: 0 additions & 5 deletions src/theme/typography.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ const family: Family = {
};

const size: Size = {
h0: pxToRem(BASE_FONT_SIZE * 2), // 32px
h1: pxToRem(BASE_FONT_SIZE * 2), // 32px
h2: pxToRem(BASE_FONT_SIZE * 1.75), // 28px
h3: pxToRem(BASE_FONT_SIZE * 1.5), // 24px
Expand Down Expand Up @@ -46,10 +45,6 @@ const lineHeight: LineHeight = {

const margin: Margin = {
heading: {
h0: {
top: pxToRem(BASE_LINE_HEIGHT * 6), // 120px
bottom: pxToRem(BASE_LINE_HEIGHT * 3), // 60px
},
h1: {
top: pxToRem(BASE_LINE_HEIGHT * 5), // 100px
bottom: pxToRem(BASE_LINE_HEIGHT * 2.5), // 50px
Expand Down
1 change: 0 additions & 1 deletion src/theme/typography.types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ export interface Family {
}

export interface Size {
h0: string;
h1: string;
h2: string;
h3: string;
Expand Down

0 comments on commit f72f2ef

Please sign in to comment.