Merge pull request #817 from securityscorecard/UXD-1138-update-links

fix(Link): update styling
securityscorecard · Sep 20, 2023 · 88b8a1b · 88b8a1b
2 parents ae79151 + 6f0d53b
commit 88b8a1b
Show file tree

Hide file tree

Showing 70 changed files with 5 additions and 5 deletions.
diff --git a/.storybook/image-snapshots/expected/components_Button_Text Buttons.png b/.storybook/image-snapshots/expected/components_Button_Text Buttons.png
diff --git a/.storybook/image-snapshots/expected/components_Callout_Info Callout.png b/.storybook/image-snapshots/expected/components_Callout_Info Callout.png
diff --git a/.storybook/image-snapshots/expected/components_Callout_Neutral Callout.png b/.storybook/image-snapshots/expected/components_Callout_Neutral Callout.png
diff --git a/.storybook/image-snapshots/expected/components_Callout_With Icon.png b/.storybook/image-snapshots/expected/components_Callout_With Icon.png
diff --git a/...s/expected/components_Datatable_internalComponents_Datatable_Minimal Config.png b/...s/expected/components_Datatable_internalComponents_Datatable_Minimal Config.png
diff --git a/...cted/components_Datatable_internalComponents_Datatable_With Applied Columns.png b/...cted/components_Datatable_internalComponents_Datatable_With Applied Columns.png
diff --git a/...ed/components_Datatable_internalComponents_Datatable_With Applied Filtering.png b/...ed/components_Datatable_internalComponents_Datatable_With Applied Filtering.png
diff --git a/...pected/components_Datatable_internalComponents_Datatable_With Batch Actions.png b/...pected/components_Datatable_internalComponents_Datatable_With Batch Actions.png
diff --git a/...s_Datatable_internalComponents_Datatable_With Custom Placeholder For Search.png b/...s_Datatable_internalComponents_Datatable_With Custom Placeholder For Search.png
diff --git a/...omponents_Datatable_internalComponents_Datatable_With Disabled Batch Module.png b/...omponents_Datatable_internalComponents_Datatable_With Disabled Batch Module.png
diff --git a/...ted/components_Datatable_internalComponents_Datatable_With Disabled Columns.png b/...ted/components_Datatable_internalComponents_Datatable_With Disabled Columns.png
diff --git a/...able_internalComponents_Datatable_With Disabled Controls And Active Columns.png b/...able_internalComponents_Datatable_With Disabled Controls And Active Columns.png
diff --git a/...ble_internalComponents_Datatable_With Disabled Controls And Applied Columns.png b/...ble_internalComponents_Datatable_With Disabled Controls And Applied Columns.png
diff --git a/...s_Datatable_internalComponents_Datatable_With Disabled Controls And Columns.png b/...s_Datatable_internalComponents_Datatable_With Disabled Controls And Columns.png
diff --git a/...ed/components_Datatable_internalComponents_Datatable_With Disabled Controls.png b/...ed/components_Datatable_internalComponents_Datatable_With Disabled Controls.png
diff --git a/...d/components_Datatable_internalComponents_Datatable_With Disabled Filtering.png b/...d/components_Datatable_internalComponents_Datatable_With Disabled Filtering.png
diff --git a/...cted/components_Datatable_internalComponents_Datatable_With Disabled Search.png b/...cted/components_Datatable_internalComponents_Datatable_With Disabled Search.png
diff --git a/...d/components_Datatable_internalComponents_Datatable_With Disabled Selection.png b/...d/components_Datatable_internalComponents_Datatable_With Disabled Selection.png
diff --git a/...onents_Datatable_internalComponents_Datatable_With Open And Applied Columns.png b/...onents_Datatable_internalComponents_Datatable_With Open And Applied Columns.png
diff --git a/...ents_Datatable_internalComponents_Datatable_With Open And Applied Filtering.png b/...ents_Datatable_internalComponents_Datatable_With Open And Applied Filtering.png
diff --git a/...xpected/components_Datatable_internalComponents_Datatable_With Open Columns.png b/...xpected/components_Datatable_internalComponents_Datatable_With Open Columns.png
diff --git a/...ected/components_Datatable_internalComponents_Datatable_With Open Filtering.png b/...ected/components_Datatable_internalComponents_Datatable_With Open Filtering.png
diff --git a/...cted/components_Datatable_internalComponents_Datatable_With Persisted State.png b/...cted/components_Datatable_internalComponents_Datatable_With Persisted State.png
diff --git a/...tatable_internalComponents_Datatable_With Selected Rows And Exclusion Logic.png b/...tatable_internalComponents_Datatable_With Selected Rows And Exclusion Logic.png
diff --git a/...pected/components_Datatable_internalComponents_Datatable_With Selected Rows.png b/...pected/components_Datatable_internalComponents_Datatable_With Selected Rows.png
diff --git a/...expected/components_Datatable_internalComponents_Datatable_With Single Page.png b/...expected/components_Datatable_internalComponents_Datatable_With Single Page.png
diff --git a/...tatable_internalComponents_Datatable_With Single Selection And Selected Row.png b/...tatable_internalComponents_Datatable_With Single Selection And Selected Row.png
diff --git a/...ted/components_Datatable_internalComponents_Datatable_With Single Selection.png b/...ted/components_Datatable_internalComponents_Datatable_With Single Selection.png
diff --git a/...ternalComponents_Table_Data Is Loading With Previous Data And Is Cancelable.png b/...ternalComponents_Table_Data Is Loading With Previous Data And Is Cancelable.png
diff --git a/...nents_Datatable_internalComponents_Table_Data Is Loading With Previous Data.png b/...nents_Datatable_internalComponents_Table_Data Is Loading With Previous Data.png
diff --git a/...shots/expected/components_Datatable_internalComponents_Table_Minimal Config.png b/...shots/expected/components_Datatable_internalComponents_Table_Minimal Config.png
diff --git a/...snapshots/expected/components_Datatable_internalComponents_Table_Playground.png b/...snapshots/expected/components_Datatable_internalComponents_Table_Playground.png
diff --git a/...xpected/components_Datatable_internalComponents_Table_With Custom Page Size.png b/...xpected/components_Datatable_internalComponents_Table_With Custom Page Size.png
diff --git a/...ected/components_Datatable_internalComponents_Table_With Disabled Selection.png b/...ected/components_Datatable_internalComponents_Table_With Disabled Selection.png
diff --git a/...cted/components_Datatable_internalComponents_Table_With Exclusive Selection.png b/...cted/components_Datatable_internalComponents_Table_With Exclusive Selection.png
diff --git a/...ots/expected/components_Datatable_internalComponents_Table_With Row Actions.png b/...ots/expected/components_Datatable_internalComponents_Table_With Row Actions.png
diff --git a/...s/expected/components_Datatable_internalComponents_Table_With Selected Rows.png b/...s/expected/components_Datatable_internalComponents_Table_With Selected Rows.png
diff --git a/...ots/expected/components_Datatable_internalComponents_Table_With Single Page.png b/...ots/expected/components_Datatable_internalComponents_Table_With Single Page.png
diff --git a/...s_Datatable_internalComponents_Table_With Single Selection And Selected Row.png b/...s_Datatable_internalComponents_Table_With Single Selection And Selected Row.png
diff --git a/...xpected/components_Datatable_internalComponents_Table_With Single Selection.png b/...xpected/components_Datatable_internalComponents_Table_With Single Selection.png
diff --git a/...s/expected/components_Datatable_internalComponents_Table_With Sorted Column.png b/...s/expected/components_Datatable_internalComponents_Table_With Sorted Column.png
diff --git a/...hots/expected/components_Datatable_internalComponents_Table_Without Sorting.png b/...hots/expected/components_Datatable_internalComponents_Table_Without Sorting.png
diff --git a/...tatable_internalComponents_Table_renderers_Discrete Link With Absolute Link.png b/...tatable_internalComponents_Table_renderers_Discrete Link With Absolute Link.png
diff --git a/...able_internalComponents_Table_renderers_Discrete Link With Custom Formatter.png b/...able_internalComponents_Table_renderers_Discrete Link With Custom Formatter.png
diff --git a/...ts_Datatable_internalComponents_Table_renderers_Discrete Link With On Click.png b/...ts_Datatable_internalComponents_Table_renderers_Discrete Link With On Click.png
diff --git a/...tatable_internalComponents_Table_renderers_Discrete Link With Relative Link.png b/...tatable_internalComponents_Table_renderers_Discrete Link With Relative Link.png
diff --git a/...nts_Datatable_internalComponents_Table_renderers_Discrete Link With Tooltip.png b/...nts_Datatable_internalComponents_Table_renderers_Discrete Link With Tooltip.png
diff --git a/...onents_Datatable_internalComponents_Table_renderers_Link With Absolute Link.png b/...onents_Datatable_internalComponents_Table_renderers_Link With Absolute Link.png
diff --git a/...nts_Datatable_internalComponents_Table_renderers_Link With Custom Formatter.png b/...nts_Datatable_internalComponents_Table_renderers_Link With Custom Formatter.png
diff --git a/.../components_Datatable_internalComponents_Table_renderers_Link With On Click.png b/.../components_Datatable_internalComponents_Table_renderers_Link With On Click.png
diff --git a/...onents_Datatable_internalComponents_Table_renderers_Link With Relative Link.png b/...onents_Datatable_internalComponents_Table_renderers_Link With Relative Link.png
diff --git a/...d/components_Datatable_internalComponents_Table_renderers_Link With Tooltip.png b/...d/components_Datatable_internalComponents_Table_renderers_Link With Tooltip.png
diff --git a/.storybook/image-snapshots/expected/components_Dropdown_Dropdown_Elevated.png b/.storybook/image-snapshots/expected/components_Dropdown_Dropdown_Elevated.png
diff --git a/.storybook/image-snapshots/expected/components_Dropdown_Dropdown_With Arrow.png b/.storybook/image-snapshots/expected/components_Dropdown_Dropdown_With Arrow.png
diff --git a/...k/image-snapshots/expected/components_Dropdown_Dropdown_With Auto Max Width.png b/...k/image-snapshots/expected/components_Dropdown_Dropdown_With Auto Max Width.png
diff --git a/...e-snapshots/expected/components_Dropdown_Dropdown_With Custom Inner Padding.png b/...e-snapshots/expected/components_Dropdown_Dropdown_With Custom Inner Padding.png
diff --git a/...image-snapshots/expected/components_Dropdown_Dropdown_With Custom Max Width.png b/...image-snapshots/expected/components_Dropdown_Dropdown_With Custom Max Width.png
diff --git a/...ed/components_FullscreenModal_Two Columns with sidebar (layout sidebar-4-6).png b/...ed/components_FullscreenModal_Two Columns with sidebar (layout sidebar-4-6).png
diff --git a/...ed/components_FullscreenModal_Two Columns with sidebar (layout sidebar-4-8).png b/...ed/components_FullscreenModal_Two Columns with sidebar (layout sidebar-4-8).png
diff --git a/.storybook/image-snapshots/expected/components_Table_Minimal Config.png b/.storybook/image-snapshots/expected/components_Table_Minimal Config.png
diff --git a/.storybook/image-snapshots/expected/components_Table_With Custom Page Size.png b/.storybook/image-snapshots/expected/components_Table_With Custom Page Size.png
diff --git a/.storybook/image-snapshots/expected/components_Table_With Row Actions.png b/.storybook/image-snapshots/expected/components_Table_With Row Actions.png
diff --git a/.storybook/image-snapshots/expected/components_Table_With Single Page.png b/.storybook/image-snapshots/expected/components_Table_With Single Page.png
diff --git a/.storybook/image-snapshots/expected/components_Table_With Sorted Column.png b/.storybook/image-snapshots/expected/components_Table_With Sorted Column.png
diff --git a/.storybook/image-snapshots/expected/components_Table_Without Sorting.png b/.storybook/image-snapshots/expected/components_Table_Without Sorting.png
diff --git a/.storybook/image-snapshots/expected/components_typography_Link_Link In Text.png b/.storybook/image-snapshots/expected/components_typography_Link_Link In Text.png
diff --git a/.storybook/image-snapshots/expected/components_typography_Link_Primary Link.png b/.storybook/image-snapshots/expected/components_typography_Link_Primary Link.png
diff --git a/.storybook/image-snapshots/expected/components_typography_Link_Secondary Link.png b/.storybook/image-snapshots/expected/components_typography_Link_Secondary Link.png
diff --git a/src/components/_internal/BaseLink/BaseLink.ts b/src/components/_internal/BaseLink/BaseLink.ts
@@ -9,23 +9,23 @@ export const LinkBaseStyles = css<LinkStylesProps>`
   margin: 0;
   border: none;
   font-family: inherit;
-  font-weight: ${getFontWeight('semibold')};
+  font-weight: ${getFontWeight('regular')};
+  text-decoration: underline;
   background-color: transparent;
   white-space: nowrap;
   cursor: pointer;
   color: ${(p) => getToken(`color-action-link-${p.$color}`, p)};
 `;
 export const LinkHoverStyles = css<LinkStylesProps>`
   color: ${(p) => getToken(`color-action-link-${p.$color}-hover`, p)};
-  text-decoration: underline;
 `;
 export const LinkFocusStyles = css<LinkStylesProps>`
   outline: 0;
   color: ${(p) => getToken(`color-action-link-${p.$color}-hover`, p)};
-  text-decoration: underline;
   background-color: ${(p) =>
-    getToken(`color-action-link-background${p.$color}-focus`, p)};
+    getToken(`color-action-link-background-${p.$color}-focus`, p)};
   border-radius: ${getRadii('default')};
+  text-decoration: none;
 `;
 export const LinkActiveStyles = css<LinkStylesProps>`
   color: ${(p) => getToken(`color-action-link-${p.$color}-active`, p)};

diff --git a/src/theme/tokens.ts b/src/theme/tokens.ts
@@ -50,7 +50,7 @@ export const createTokens = (
   'color-action-link-primary-active': colors.primary[600],
   'color-action-link-background-primary-focus': colors.primary[50],
   'color-action-link-secondary': colors.neutral[1000],
-  'color-action-link-secondary-hover': colors.neutral[800],
+  'color-action-link-secondary-hover': colors.neutral[700],
   'color-action-link-secondary-active': colors.neutral[1000],
   'color-action-link-background-secondary-focus': colors.neutral[200],