feat(Checkbox): make checkboxId required

securityscorecard · Nov 29, 2023 · 7833266 · 7833266
1 parent 6823fb8
commit 7833266
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/src/components/forms/Checkbox/Checkbox.tsx b/src/components/forms/Checkbox/Checkbox.tsx
@@ -181,7 +181,7 @@ const Checkbox = forwardRef<HTMLInputElement, CheckboxProps>(
 
 Checkbox.propTypes = {
   name: PropTypes.string.isRequired,
-  checkboxId: PropTypes.string,
+  checkboxId: PropTypes.string.isRequired,
   label: PropTypes.node,
   className: PropTypes.string,
   isDisabled: PropTypes.bool,

diff --git a/src/components/forms/Checkbox/Checkbox.types.ts b/src/components/forms/Checkbox/Checkbox.types.ts
@@ -1,6 +1,6 @@
 import { TogglingProps } from '../types/forms.types';
 
 export interface CheckboxProps extends TogglingProps {
-  checkboxId?: string;
+  checkboxId: string;
   className?: string;
 }
diff --git a/src/components/forms/Select/Select.styles.tsx b/src/components/forms/Select/Select.styles.tsx
@@ -485,6 +485,7 @@ export const Option: ComponentType<OptionProps<OptionType, boolean>> = (
       <components.Option {...props}>
         <Inline gap={SpaceSizes.sm}>
           <Checkbox
+            checkboxId="select"
             checked={isSelected}
             isDisabled={isDisabled}
             label={children}