Split out export and initial v5.0 work. #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcelevel-bot[bot]](https://avatars.githubusercontent.com/in/597?s=60&v=4){kind=small}
example/split.js
Outdated
| import { render } from 'react-dom'; | ||
| import SplitAceEditor from '../src/split.jsx'; | ||
| import AceEditor from '../src/ace.jsx'; | ||
| import brace from 'brace'; |
There was a problem hiding this comment.
'brace' is defined but never used.
example/split.js
Outdated
| import React, { Component } from 'react'; | ||
| import { render } from 'react-dom'; | ||
| import SplitAceEditor from '../src/split.jsx'; | ||
| import AceEditor from '../src/ace.jsx'; |
There was a problem hiding this comment.
'AceEditor' is defined but never used.
Closed
Activating Open Collective
- Adds support for the split editor component. - Allows for the export of multiple child components in addition to ReactAce being default
securingsincity
force-pushed
the
split-out-export
branch
from
71bd176
to
06aca13
Compare
example/index.js
Outdated
| name: 'myTestCommand', | ||
| bindKey: {win: 'Ctrl-W', mac: 'Command-W'}, | ||
| exec: () => { | ||
| console.log("this coammdb or whatever") |
There was a problem hiding this comment.
Strings must use singlequote.
example/index.js
Outdated
| name: 'myReactAceTest', | ||
| bindKey: {win: 'Ctrl-M', mac: 'Command-M'}, | ||
| exec: () => { | ||
| console.log("this coammdb or whatever") |
There was a problem hiding this comment.
Strings must use singlequote.
|
Ebert has finished reviewing this Pull Request and has found:
You can see more details about this review at https://ebertapp.io/github/securingsincity/react-ace/pulls/205. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.