Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update sigstore/scaffold version & chart version #175

Merged
merged 2 commits into from
Feb 2, 2024

Conversation

sallyom
Copy link
Collaborator

@sallyom sallyom commented Feb 1, 2024

/cc @cooktheryan @Gregory-Pereira @JasonPowr
This PR:

  1. updates sigstore/scaffold chart
  2. adds results of pre-commit run --all-files (the test for this should be run automatically from this branch! it's only running from main.

Resolves https://issues.redhat.com/browse/SECURESIGN-372

Copy link
Contributor

@Gregory-Pereira Gregory-Pereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this,
/lgtm

@Gregory-Pereira
Copy link
Contributor

@sallyom this seems to fail the test with the following error:
Error: INSTALLATION FAILED: client rate limiter Wait returned an error: rate: Wait(n=1) would exceed context deadline. I found this thread (helm/helm#12154 (comment)) which gave a little background on it. Basically it is just failing due to timeout so the cause is still unclear. If some of the pods could be crashlooping or crashbackoffing and its possible that helm is just not propegating that error back to us, it seems like it is a newish error message. I would try it somewhere you can go into the cluster and validate the deployment. If this doesnt work, I would try specifiying the timeout as a fixed number rather using the --wait flag.

@JasonPowr
Copy link
Contributor

if you run the test locally you should be able to see whats failing and why its failing, but I'm fairly certain its because the images are pointing to regisrty.redhat.io
re: https://redhat-internal.slack.com/archives/C05M2GGKU7Q/p1706795535218619

@sallyom sallyom force-pushed the update-scaffold-version branch from 2f8bec4 to e77c2b5 Compare February 2, 2024 17:14
Copy link
Contributor

@Gregory-Pereira Gregory-Pereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm. Thank you!

@Gregory-Pereira Gregory-Pereira merged commit ded4260 into release-1.0.gamma Feb 2, 2024
2 checks passed
Gregory-Pereira pushed a commit that referenced this pull request Feb 26, 2024
* update sigstore/scaffold version, chart version and  images in values.yaml

Signed-off-by: sallyom <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants