Build-time variables to set url and version of chart #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* enable keycloak install with binary * enable cert setup * configure pull secret * update pull secret logic, add rekor/fulcio secret * add helm installation * handle backup segment job
Signed-off-by: Sally O'Malley <[email protected]> rh-pre-commit.version: 2.0.3 rh-pre-commit.check-secrets: ENABLED
rh-pre-commit.version: 2.0.3 rh-pre-commit.check-secrets: ENABLED
rh-pre-commit.version: 2.0.3 rh-pre-commit.check-secrets: ENABLED
rh-pre-commit.version: 2.0.3 rh-pre-commit.check-secrets: ENABLED
rh-pre-commit.version: 2.0.3 rh-pre-commit.check-secrets: ENABLED
rh-pre-commit.version: 2.0.3 rh-pre-commit.check-secrets: ENABLED
rh-pre-commit.version: 2.0.3 rh-pre-commit.check-secrets: ENABLED
rh-pre-commit.version: 2.0.3 rh-pre-commit.check-secrets: ENABLED
rh-pre-commit.version: 2.0.3 rh-pre-commit.check-secrets: ENABLED
rh-pre-commit.version: 2.0.3 rh-pre-commit.check-secrets: ENABLED
rh-pre-commit.version: 2.0.3 rh-pre-commit.check-secrets: ENABLED
JasonPowr
reviewed
Dec 8, 2023
lance
reviewed
Dec 8, 2023
| @@ -0,0 +1,37 @@ | |||
|
|
|||
| CHART_VERSION ?= "" | |||
| CHART_URL ?= "./charts/trusted-artifact-signer" | |||
There was a problem hiding this comment.
Can this be the full git URL instead? I would like for end users to not need to git clone the repo
There was a problem hiding this comment.
It looks like we have to package chart to tgz if we want to install it via http. From helm doc:
There are six different ways you can express the chart you want to install:
- By chart reference: helm install mymaria example/mariadb
- By path to a packaged chart: helm install mynginx ./nginx-1.2.3.tgz
- By path to an unpacked chart directory: helm install mynginx ./nginx
- By absolute URL: helm install mynginx https://example.com/charts/nginx-1.2.3.tgz
- By chart reference and repo url: helm install --repo https://example.com/charts/ mynginx nginx
- By OCI registries: helm install mynginx --version 1.2.3 oci://example.com/charts/nginx
sallyom
force-pushed
the
add-uninstall
branch
3 times, most recently
from
4b90414 to
a23da21
Compare
|
@osmman please rebase - @JasonPowr or I will review/merge Monday! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #118
Changes:
Usage:
Dev
Build installer which use by default Helm Chart from ./charts/trusted-artifact-signer path.
make buildProd
Compile with reseted default values to use released oci helm chart
CHART_VERSION=0.1.24 CHART_URL='oci://quay.io/redhat-user-workloads/arewm-tenant/sigstore-ocp/trusted-artifact-signer' make build