Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rekor): delete unassigned sharding configmaps #695

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

osmman
Copy link
Contributor

@osmman osmman commented Oct 22, 2024

sharding config is another resource which could be recreated without any problem

Changes:

  • Modified the sharding configuration resource management to recreate the config rather than reusing it.
  • Updated the cleanup procedure to take place after the new sharding configuration is successfully created

Copy link

openshift-ci bot commented Oct 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: osmman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@osmman osmman force-pushed the tturek/rekor-sharding-config branch from b0e1eec to a3212a7 Compare October 22, 2024 16:15
@osmman osmman requested a review from bouskaJ October 22, 2024 17:09
@bouskaJ
Copy link
Collaborator

bouskaJ commented Oct 23, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 23, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit cf329cd into main Oct 23, 2024
15 checks passed
@osmman osmman added this to the 1.1.0 milestone Oct 23, 2024
@osmman osmman deleted the tturek/rekor-sharding-config branch November 7, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants