Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SECURESIGN-1461: check if Trillian's secret with db connection already exists #674

Merged
merged 2 commits into from
Oct 10, 2024
Merged

SECURESIGN-1461: check if Trillian's secret with db connection already exists #674

merged 2 commits into from
Oct 10, 2024

Conversation

osmman
Copy link
Contributor

@osmman osmman commented Oct 8, 2024 •
edited by openshift-ci bot
Loading

fixes SECURESIGN-1461
depends on #673

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Oct 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: osmman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Oct 8, 2024
@osmman osmman marked this pull request as draft October 8, 2024 15:03
@osmman osmman changed the title refactor: constants for app.kubernetes.io labels SECURESIGN-1461: check if Trillian's secret with db connection already exists Oct 8, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 8, 2024 •
edited by openshift-ci bot
Loading

@osmman: This pull request references SECURESIGN-1461 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.18.0" version, but no target version was set.

In response to this:

fixes SECURESIGN-1461
depends on #673

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@osmman osmman force-pushed the tturek/SECURESIGN-1461 branch 3 times, most recently from 9d69274 to b0512b2 Compare October 9, 2024 13:56
@osmman osmman marked this pull request as ready for review October 9, 2024 13:58
@openshift-ci openshift-ci bot requested a review from JasonPowr October 9, 2024 13:58
@osmman osmman force-pushed the tturek/SECURESIGN-1461 branch 2 times, most recently from 4ada8dc to bb02958 Compare October 9, 2024 14:00
@osmman osmman requested a review from bouskaJ October 9, 2024 14:33
@osmman osmman force-pushed the tturek/SECURESIGN-1461 branch 3 times, most recently from 51c786e to 8895ad8 Compare October 9, 2024 16:04
@osmman osmman requested review from bouskaJ October 9, 2024 16:05
@osmman osmman force-pushed the tturek/SECURESIGN-1461 branch 2 times, most recently from af45c4d to 1ec4421 Compare October 10, 2024 08:17
@bouskaJ
Copy link
Collaborator

bouskaJ commented Oct 10, 2024

/lgtm
/retest

@openshift-ci openshift-ci bot added the lgtm label Oct 10, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 6de1e4f into main Oct 10, 2024
15 checks passed
@osmman osmman deleted the tturek/SECURESIGN-1461 branch October 10, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cooktheryan cooktheryan Awaiting requested review from cooktheryan

@lance lance Awaiting requested review from lance

@JasonPowr JasonPowr Awaiting requested review from JasonPowr

@bouskaJ bouskaJ Awaiting requested review from bouskaJ

Assignees

@bouskaJ bouskaJ

Labels
approved jira/valid-reference lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@osmman @openshift-ci-robot @bouskaJ