Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SECURESIGN-150 | Modify the screen shown on successful authentication with cosign #101

Merged
merged 2 commits into from
Dec 6, 2023
Merged

SECURESIGN-150 | Modify the screen shown on successful authentication with cosign #101

merged 2 commits into from
Dec 6, 2023

Conversation

JasonPowr
Copy link

This pr adds the changes necessary to update the landing page when a user authenticates with keycloak.

Testing

  1. Apply the overlay files
  2. Make sure you are using a fresh build of cosign created after the overlay files are applied
  3. Stand up a cluster
  4. Using key cloak and the new cosign binary sign and verify an image
  5. You should be brought to the new landing page instead of the old one

Before

image

After

Screenshot from 2023-11-02 15-41-38

lance
lance reviewed Dec 4, 2023
View reviewed changes
cmd/cosign/cli/fulcio/fulcio.go Outdated Show resolved Hide resolved
internal/ui/index.go Outdated Show resolved Hide resolved
@JasonPowr
Copy link
Author

@lance :)

Gregory-Pereira
Gregory-Pereira approved these changes Dec 5, 2023
View reviewed changes
Copy link

@Gregory-Pereira Gregory-Pereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hats off Jason, this looks awesome.
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Dec 5, 2023
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 5, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Gregory-Pereira, JasonPowr

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lance lance merged commit df78808 into securesign:redhat-v2.2 Dec 6, 2023
18 of 21 checks passed
@JasonPowr JasonPowr mentioned this pull request Mar 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance lance lance left review comments

@Gregory-Pereira Gregory-Pereira Gregory-Pereira approved these changes

Assignees

@Gregory-Pereira Gregory-Pereira

Labels
lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JasonPowr @lance @Gregory-Pereira