Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] [SECURESIGN-1464] & [SECURESIGN-1193] | Adding Custom Key, Custom Config and Sharding Support for CTlog #90

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

tommyd450
Copy link
Collaborator

@tommyd450 tommyd450 commented Nov 4, 2024

As it stands Keys can be added as a variable in roles/tas_single_node/defaults/main.yml.
Custom Config will follow soon but will need to add custom treeId specifications.

When testing ensure the keys and or config you provide are inputed like the following:

tas_single_node_custom_ctlog_private_key: |
    <Key Here>

Update: Looking into creating a secret template so we can allow for easy management of keys within secrets removing the need to hardcode them within the config files.

@tommyd450 tommyd450 requested a review from a team as a code owner November 4, 2024 11:34
@tommyd450 tommyd450 force-pushed the tdalton/SECURESIGN-1464 branch from 0b9f7b0 to 6c5c377 Compare November 6, 2024 10:42
@tommyd450 tommyd450 requested a review from SequeI November 6, 2024 10:58
@tommyd450 tommyd450 changed the title [WIP] [SECURESIN-1464] | Adding Custom Key and Config Support for CTlog [SECURESIN-1464] | Adding Custom Key and Config Support for CTlog Nov 6, 2024
Copy link
Collaborator

@SequeI SequeI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for fixing the issue

@SequeI
Copy link
Collaborator

SequeI commented Nov 7, 2024

@tommyd450 If you so wish, you could add a testdata folder and add this to our new user_provided scenario so it can be tested within our CI. Can be added in another PR once we finish up other user provisioned tickets though so no worries

@tommyd450
Copy link
Collaborator Author

@tommyd450 If you so wish, you could add a testdata folder and add this to our new user_provided scenario so it can be tested within our CI. Can be added in another PR once we finish up other user provisioned tickets though so no worries

Will do

@tommyd450 tommyd450 force-pushed the tdalton/SECURESIGN-1464 branch from b9599e1 to 862cc0c Compare November 13, 2024 11:05
@SequeI
Copy link
Collaborator

SequeI commented Nov 13, 2024

@tommyd450 Please add new ctlog config to our docs since it can get pretty confusing for users with the whole setup
(When you are done of course)
Thanks

@tommyd450 tommyd450 force-pushed the tdalton/SECURESIGN-1464 branch from 9e25831 to e1c5883 Compare December 3, 2024 08:56
@tommyd450 tommyd450 requested a review from ritz303 as a code owner December 3, 2024 08:56
@tommyd450 tommyd450 force-pushed the tdalton/SECURESIGN-1464 branch from 0e9ca68 to dd5dd3a Compare December 3, 2024 09:19
@tommyd450 tommyd450 changed the title [SECURESIN-1464] | Adding Custom Key and Config Support for CTlog [SECURESIGN-1464] & [SECURESIGN-1193] | Adding Custom Key, Custom Config and Sharding Support for CTlog Dec 3, 2024
@tommyd450 tommyd450 changed the title [SECURESIGN-1464] & [SECURESIGN-1193] | Adding Custom Key, Custom Config and Sharding Support for CTlog [WIP] [SECURESIGN-1464] & [SECURESIGN-1193] | Adding Custom Key, Custom Config and Sharding Support for CTlog Dec 3, 2024
@SequeI SequeI force-pushed the tdalton/SECURESIGN-1464 branch from 12b4b33 to f48b9b3 Compare January 10, 2025 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants