Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SECURESIGN-1659] Add AAP testing scenario for collection #119

Open
wants to merge 110 commits into
base: main
Choose a base branch
from

Conversation

fghanmi
Copy link
Collaborator

@fghanmi fghanmi commented Dec 23, 2024

No description provided.

@fghanmi fghanmi requested a review from a team as a code owner December 23, 2024 10:51
@fghanmi fghanmi changed the title [on-going] add aap ci test [In progress] add aap ci test Dec 23, 2024
@fghanmi fghanmi removed the request for review from a team December 23, 2024 15:06
molecule reset
molecule -v create --scenario-name aap-setup
molecule -v converge --scenario-name aap-setup
molecule -v test --scenario-name aap-collection-test
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this isn't using Molecule as it was meant to be used. This whole "setup" should be a part of the prepare.yml file inside the same Molecule scenario.

Furthermore, we shouldn't install the collection from AAP and run it locally, we want AAP to use it. Let me explain in more detail:

Does that make sense? The important point here is that we need to test not only uploading the collection to AAP, but we need to ensure that it executes correctly from AAP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants