-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SECURESIGN-1659] Add AAP testing scenario for collection #119
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Firas Ghanmi <[email protected]>
.github/workflows/aap.yaml
Outdated
molecule reset | ||
molecule -v create --scenario-name aap-setup | ||
molecule -v converge --scenario-name aap-setup | ||
molecule -v test --scenario-name aap-collection-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this isn't using Molecule as it was meant to be used. This whole "setup" should be a part of the prepare.yml
file inside the same Molecule scenario.
Furthermore, we shouldn't install the collection from AAP and run it locally, we want AAP to use it. Let me explain in more detail:
- Have 1 Molecule testing scenario, which creates 2 VMs
- In
prepare.yml
:- Install AAP on one of the VMs
- Upload the collection to AAP
- Create all AAP objects necessary to run the collection from AAP (something similar to https://docs.redhat.com/en/documentation/red_hat_ansible_automation_platform/2.4/html/developing_ansible_automation_content/publishing-playbook-collection-aap#create-aap-job_publishing-playbook-collection-aap-intro)
- In
converge.yml
:- Trigger the AAP job and poll until it finishes
- In
verify.yml
:- Verify that TAS was installed correctly (e.g. use the verify from the
default
Molecule scenario)
- Verify that TAS was installed correctly (e.g. use the verify from the
Does that make sense? The important point here is that we need to test not only uploading the collection to AAP, but we need to ensure that it executes correctly from AAP.
No description provided.