SECURESIGN-55 | Monitoring of Sigstore containers with Cockpit #112
Conversation
JasonPowr
force-pushed
the
enable-monitoring-with-cockpit
branch
2 times, most recently
from
64d0422 to
7f53c05
Compare
|
@bkabrda When you get a chance can you take a look at this?, To me, it didn't make sense to add 'redhat.rhel_system_roles' as a dependency since cockpit is optional wdyt?, and please correct me if I am wrong |
JasonPowr
force-pushed
the
enable-monitoring-with-cockpit
branch
from
6506bf6 to
949be35
Compare
JasonPowr
force-pushed
the
enable-monitoring-with-cockpit
branch
3 times, most recently
from
5463656 to
a1412f4
Compare
There was a problem hiding this comment.
Hi Jason, nice job! I provided some inline comments to address. I think it's good to not depend on the rhel system role if we don't require it by default. However, I think in this case the README should list a minimum version of that collection that we guarantee will work.
README.md
Outdated
| sudo usermod -aG wheel cockpit-user | ||
| ``` | ||
|
|
||
| Note: You may need to log out and then log back in to the Cockpit interface for these changes to take effect. |
There was a problem hiding this comment.
It's nice to have these commands, but how about we provide them as a set of tasks that are run optionally, so that user can just set a variable to true and get this set up by the role?
There was a problem hiding this comment.
Sure ofc, never even thought of doing that but now that you mention that makes sense :)
JasonPowr
force-pushed
the
enable-monitoring-with-cockpit
branch
2 times, most recently
from
9f4c976 to
3ae3b66
Compare
JasonPowr
force-pushed
the
enable-monitoring-with-cockpit
branch
from
3ae3b66 to
aec7e52
Compare
JasonPowr
force-pushed
the
enable-monitoring-with-cockpit
branch
from
e290588 to
4b7907e
Compare
No description provided.