Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve suppressions handling #1050

Merged
merged 3 commits into from
Oct 18, 2023
Merged

Improve suppressions handling #1050

merged 3 commits into from
Oct 18, 2023

Conversation

ccojocar
Copy link
Member

  • Ensure the ignores are parsed before analysing the package
  • Update README with details which describe the current behaviour of #nosec

fixes #1046

In addition this handles the ignores for multi-line issues

Signed-off-by: Cosmin Cojocar <[email protected]>
Signed-off-by: Cosmin Cojocar <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (7846db0) 72.30% compared to head (e89b7b1) 72.07%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1050      +/-   ##
==========================================
- Coverage   72.30%   72.07%   -0.23%     
==========================================
  Files          50       50              
  Lines        3394     3438      +44     
==========================================
+ Hits         2454     2478      +24     
- Misses        868      884      +16     
- Partials       72       76       +4     
Files Coverage Δ
analyzer.go 84.23% <73.13%> (-3.27%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ccojocar ccojocar merged commit e108c56 into master Oct 18, 2023
7 checks passed
@ccojocar ccojocar deleted the fix-suppressions branch May 13, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression of '#nosec' handling
2 participants