Horovod demo #899
Merged
Horovod demo #899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@porteratzo could you add a description to this PR? |
psfoley
requested changes
Feb 22, 2024
There was a problem hiding this comment.
This is a great contribution, @porteratzo. A couple small requested changes, and then I think this is ready to merge.
openfl-tutorials/experimental/Federeated_Pytorch_LLM_Horovod.py
Outdated
Show resolved
Hide resolved
psfoley
approved these changes
Feb 23, 2024
nammbash
pushed a commit
to nammbash/openfl
that referenced
this pull request
Feb 27, 2024
* initial commit * changes * name changes, added readme * remove files, new dataloader inherit * move files, flake changes * flake fix --------- Co-authored-by: Patrick Foley <[email protected]> Signed-off-by: nammbash <[email protected]>
nammbash
pushed a commit
to nammbash/openfl
that referenced
this pull request
Feb 27, 2024
* initial commit * changes * name changes, added readme * remove files, new dataloader inherit * move files, flake changes * flake fix --------- Co-authored-by: Patrick Foley <[email protected]> Signed-off-by: nammbash <[email protected]>
nammbash
pushed a commit
to nammbash/openfl
that referenced
this pull request
Feb 29, 2024
* initial commit * changes * name changes, added readme * remove files, new dataloader inherit * move files, flake changes * flake fix --------- Co-authored-by: Patrick Foley <[email protected]> Signed-off-by: nammbash <[email protected]>
nammbash
pushed a commit
to nammbash/openfl
that referenced
this pull request
Feb 29, 2024
* initial commit * changes * name changes, added readme * remove files, new dataloader inherit * move files, flake changes * flake fix --------- Co-authored-by: Patrick Foley <[email protected]> Signed-off-by: nammbash <[email protected]>
manuelhsantana
pushed a commit
that referenced
this pull request
Jul 10, 2024
* initial commit * changes * name changes, added readme * remove files, new dataloader inherit * move files, flake changes * flake fix --------- Co-authored-by: Patrick Foley <[email protected]> Signed-off-by: manuelhsantana <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to integrate a new workspace template called torch_llm_horovod, it uses pt_model as the collaborator task runner and launches a horovod cluster in the train_batches and validate steps with launch_horovod, this launches in InHorovodrun.py which creates the LLMTrainer and loads the datasets and trains or validates the model. The taskrunner and dataloader in the collaborator handles saving the data and model state for the LLMTrainer to load and return to the taskrunner.