Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update python annotations to 3.9 #894

Merged
merged 1 commit into from
Oct 25, 2024
Merged

update python annotations to 3.9 #894

merged 1 commit into from
Oct 25, 2024

Conversation

NicholasTanz
Copy link
Contributor

Description of the changes being introduced by the pull request:

Fixes #887

@NicholasTanz NicholasTanz marked this pull request as ready for review October 20, 2024 04:59
@NicholasTanz
Copy link
Contributor Author

Hi @jku, when you get a chance, could you take a look at this PR

jku
jku approved these changes Oct 21, 2024
View reviewed changes
Copy link
Collaborator

@jku jku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this looks good to me.

This bumps requires-python so we might not be in a hurry to release it ... but IMO keeping up with new features is ultimately useful.

@jku jku merged commit dc6186e into secure-systems-lab:main Oct 25, 2024
16 checks passed
@NicholasTanz NicholasTanz deleted the updateAnnotations branch October 25, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jku jku jku approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update annotations to python 3.9
2 participants
@NicholasTanz @jku