Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VaultSigner test unexpectedly does not depend on environment variables #888

Closed
wants to merge 6 commits into from
Closed

VaultSigner test unexpectedly does not depend on environment variables #888

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
428ba35
set vault_addr with non-default port and specify addr/token when star…
NicholasTanz Oct 12, 2024
b77d0d1
Merge branch 'secure-systems-lab:main' into vaultsigner
NicholasTanz Oct 28, 2024
4c2046f
change to use default port
NicholasTanz Oct 29, 2024
1bf96df
remove -dev-no-store-token option
NicholasTanz Oct 29, 2024
5872d2e
remove comment + add back in option
NicholasTanz Oct 29, 2024
bb3bacc
change back to non-default port 8200 -> 8201
NicholasTanz Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion tests/scripts/init-vault.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
#!/usr/bin/env bash

vault server -dev -dev-root-token-id="${VAULT_TOKEN}" &
vault server -dev \
-dev-listen-address="${VAULT_ADDR#http://}" \
-dev-root-token-id="${VAULT_TOKEN}" \
-dev-no-store-token \
&

until vault status
do
Expand Down
2 changes: 1 addition & 1 deletion tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ allowlist_externals =
bash

setenv =
VAULT_ADDR = http://localhost:8200
VAULT_ADDR = http://localhost:8201
VAULT_TOKEN = test-root-token

commands_pre =
Expand Down