Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.pre-commit-config.yaml updated with ruff #835

Merged
merged 3 commits into from
Jul 2, 2024

Conversation

L77H
Copy link
Contributor

@L77H L77H commented Jun 27, 2024

Description of the changes being introduced by the pull request:

  • isort removed from pre-commit
  • black removed rom pre-commit
  • ruff added to pre-commit
  • ruff-format added to pre-commit

see also: https://github.com/astral-sh/ruff-pre-commit

Fixes #831

Copy link
Collaborator

@jku jku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I wonder if this should run ruff with --fix?

I dont use pre-commit so I'm not sure

@L77H
Copy link
Contributor Author

L77H commented Jun 27, 2024

As I understand when using --fix it immediately fixes any fixable errors, while without --fix it just outputs the linting errors. see: https://docs.astral.sh/ruff/linter/#ruff-check

It would be a good idea to include it and run ruff-format after, as the ruff format should never introduce new linting errors.

@jku
Copy link
Collaborator

jku commented Jun 27, 2024

Looks good to me but I'll let Lukas approve this next week as I think he uses pre-commit

@lukpueh
Copy link
Member

lukpueh commented Jul 1, 2024

Thanks for the patch, @L77H! I'm okay, if we remove the pre-commit config entirely as discussed here: #734

@L77H
Copy link
Contributor Author

L77H commented Jul 1, 2024

I have removed the pre-commit config file entirely.

Copy link
Collaborator

@jku jku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@jku jku merged commit f47fc51 into secure-systems-lab:main Jul 2, 2024
14 checks passed
@L77H L77H deleted the modify-pre-commit branch July 2, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

modify pre-commit-config.yaml
3 participants