Fix verify test with ecdsa-sha2-nistp384 key #794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukpueh
added a commit
to lukpueh/securesystemslib
that referenced
this pull request
Apr 24, 2024
Added checks as requrested in secure-systems-lab#766: - keytype matches scheme - scheme matches deserialized key type (only for pem formatted keyvals; for ed25519 the check happens implicitly on deserialization) - scheme matches deserialized key curve (only for ecdsa) Note that this PR does not move the checks to the constructor as suggested in secure-systems-lab#766. This may or may not be addressed in a follow-up PR. failing tests fixed in secure-systems-lab#794 Signed-off-by: Lukas Puehringer <[email protected]>
lukpueh
added a commit
to lukpueh/securesystemslib
that referenced
this pull request
Apr 24, 2024
Added checks as requrested in secure-systems-lab#766: - keytype matches scheme - scheme matches deserialized key type (only for pem formatted keyvals; for ed25519 the check happens implicitly on deserialization) - scheme matches deserialized key curve (only for ecdsa) Note that this PR does not move the checks to the constructor as suggested in secure-systems-lab#766. This may or may not be addressed in a follow-up PR. failing tests fixed in secure-systems-lab#794 Signed-off-by: Lukas Puehringer <[email protected]>
Fix test, which successfully verifies a signature from an ecdsa nistp256 key, using a "ecdsa-sha2-nistp384" key. This only worked because keytype/scheme/keyval combos in an SSlibKey are not validated sufficiently (see secure-systems-lab#766). The test data was created using below snippet. Note how the signature is not created with CryptoSigner, which does not support nistp384. ``` from cryptography.hazmat.primitives.asymmetric.ec import ( ECDSA, SECP384R1, EllipticCurvePrivateKey, ) from cryptography.hazmat.primitives.hashes import SHA384 from cryptography.hazmat.primitives.serialization import load_pem_private_key from securesystemslib.signer import SSlibKey with open("tests/data/pems/ecdsa_secp384r1_private.pem", "rb") as f: priv: EllipticCurvePrivateKey = load_pem_private_key(f.read(), None) assert isinstance(priv.curve, SECP384R1) pub = SSlibKey.from_crypto(priv.public_key()) sig = priv.sign(b"DATA", ECDSA(SHA384())) print(pub.keyid) print(sig.hex()) print(repr(pub.keyval["public"]).strip("'")) ``` Signed-off-by: Lukas Puehringer <[email protected]>
jku
approved these changes
Apr 25, 2024
lukpueh
added a commit
to lukpueh/securesystemslib
that referenced
this pull request
Apr 25, 2024
Added checks as requrested in secure-systems-lab#766: - keytype matches scheme - scheme matches deserialized key type (only for pem formatted keyvals; for ed25519 the check happens implicitly on deserialization) - scheme matches deserialized key curve (only for ecdsa) Note that this PR does not move the checks to the constructor as suggested in secure-systems-lab#766. This may or may not be addressed in a follow-up PR. failing tests fixed in secure-systems-lab#794 Signed-off-by: Lukas Puehringer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix test, which successfully verifies a signature from an ecdsa nistp256 key, using a "ecdsa-sha2-nistp384" key.
This only worked because keytype/scheme/keyval combos in an SSlibKey are not validated sufficiently (see #766).
The test data was created using a snippet attached to the commit message. Note how the signature is not created with
CryptoSigner, which does not support nistp384.