Simplify and strengthen AWSSigner.import_ #778
Merged
+46
−65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Simplify** - remove redundant keytype/scheme switches - remove try/except, which catches an exception only to re-raise it **Strengthen** - choose default scheme based on schemes supported by the key Roughly implements the algorithm suggested in: secure-systems-lab#724 (review) **Unrelated changes** - fix secure-systems-lab#765 fix typo AND disable scheme until SSlibKey adds support - fail in __init__ if public_key.scheme is not in aws_algos **TODO** * add tests Many thanks to @ianhundere for the solid ground work! Signed-off-by: Lukas Puehringer <[email protected]>
lukpueh
force-pushed
the
simplify-aws-signer
branch
from
bcfae9d to
587cf38
Compare
Test coverage is actually pretty good, especially compared to other cloud KMS signers. It tests the full Signer API flow -- import (with and without passed scheme), load, sign, verify (pass and fail) for all supported schemes. What's missing are tests for some failure cases, like AWS returning an unsupported key, etc. I think we can improve this in a future PRs. |
jku
approved these changes
Apr 12, 2024
You are right, it was a bit sneaky of me to not mention this. Apologies! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify
Strengthen
Roughly implements the algorithm suggested in: #724 (review)
Unrelated changes
__init__if public_key.scheme is not in aws_algosTODO:
Many thanks to @ianhundere for the solid ground work!