Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused function and schema checks in hash #774

Merged
merged 1 commit into from
Apr 16, 2024

Commits on Apr 15, 2024

  1. Remove unused function and schema checks in hash

    In prepartion for the removal of schema.py (secure-systems-lab#183), this patch removes
    schema checks of function arguments in hash.py and one entire function.
    
    The removed checks are obfuscated "is string" checks, and without them
    invalid args are still caught in the `digest` function, where they all
    end up and raise a more meaningful UnsupportedLibraryError or
    UnsupportedAlgorithmError if invalid.
    
    The removed function `digest_from_rsa_scheme` doesn't seem to be used
    anywhere (according to sourcegraph.com) not even in
    securesystemslib.signer, where the same functionality is replicated
    several times (see secure-systems-lab#594). Removing it here allows to ignore a
    slightly more complex schema check.
    
    Signed-off-by: Lukas Puehringer <[email protected]>
    lukpueh committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    aef86c6 View commit details
    Browse the repository at this point in the history