Fix ed25519 upstream check #666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, I missed this PR. @jku, do you mind fixing the conflicts? Then I'll review right away. |
github-script v5 no longer offers the rest methods directly on the github object, instead they are available only in github.rest. https://github.com/actions/github-script#breaking-changes-in-v5
jku
force-pushed
the
fix-ed25519-upstream-check
branch
from
4e648bf to
fe4b578
Compare
|
I removed the improvements to uses lines, should be a clean merge now |
|
this does seem fixed but the workflow still fails with 'Resource not accessible by integration' when it tries to create an issue... I wonder if some setting was changed meanwhile? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #651
Upgrading to github-script v5 broke this (should have read the changelog more carefully...) but the fix seems to be easy