Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lint issues #490

Merged
merged 4 commits into from
Jan 10, 2023
Merged

Fix lint issues #490

merged 4 commits into from
Jan 10, 2023

Conversation

jku
Copy link
Collaborator

@jku jku commented Dec 27, 2022 •
edited
Loading

Handle linter issues:

  • unused-variable: remove variables altogether or name them "_".
  • unused-import: remove import
  • consider-using-from-import: Use from-import
  • no-else-raise: remove unnecessary "else"
  • consider-using-enumerate: stop using range(len(..))
  • unnecessary-pass: Remove unnecessary pass

In addition:

  • Remove version checks for python <=3.3
  • some very minor import order changes because of the other changes:
  • reflow some error message formatting code

I expect no functionality changes at all.

Fixes #432

jku added 4 commits December 29, 2022 16:57
@jku
Fix lint issues
de9a29f 
* unused-variable: remove variables altogether or name them "_".
* unused-import: remove import
* consider-using-from-import: Use from-import
* Remove version checks for python <=3.3

There are some very minor import order changes: I expect no
functionality changes.

Fixes secure-systems-lab#432
@jku
lint: Remove unnecessary "pass"
4c52131
@jku
lint: Avoid using "range(len(...))"
0306ab2
@jku
lint: Don't use "else" when it's not needed
7068b33 
Reflow some related error message formatting as well: no functional changes
lukpueh
lukpueh approved these changes Jan 10, 2023
View reviewed changes
Copy link
Member

@lukpueh lukpueh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@lukpueh lukpueh merged commit c10b0e9 into secure-systems-lab:master Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukpueh lukpueh lukpueh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unused variables and constants
2 participants
@jku @lukpueh