WIP: Fix implementation of abstract base classes (ABCs) to use Python3 syntax #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The __metaclass__ attribute was removed in Python3 and the correct way to specify a metaclass in Python 3 is the metaclasss keyword argument: https://peps.python.org/pep-3115/ Signed-off-by: Joshua Lock <[email protected]>
The __metaclass__ attribute was removed in Python3 and the correct way to specify a metaclass in Python 3 is the metaclasss keyword argument: https://peps.python.org/pep-3115/ Signed-off-by: Joshua Lock <[email protected]>
|
Before we fix our usage of abc, I'm curious to hear what you think about using Protocol (see #463 (comment)). |
|
#456 resolves this issue for I'll close this PR and open a new one addressing only |
I think I actually only fixed Key (that is moved from pythontuf). But let's fix signer afterwards... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #463
Description of the changes being introduced by the pull request:
Update the
SignerandStorageBackendInterfacebases classes to be abstract base classes. Due to the removal of the__metaclass__attribute in Python 3 the current implementations are standard classes which can be instantiated.The correct way to specify a metaclass in Python 3 is the metaclasss keyword argument: https://peps.python.org/pep-3115/
NOTE: this is marked as draft because I have not yet tested any securesystemslib dependents with this change.
Please verify and check that the pull request fulfils the following requirements: