Strip public key pem value #457
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a call to strip the public key pem value in import_ecdsakey_from_private_pem. The motivation for this that a later call to import_ecdsakey_from_public_pem will otherwise cause an incorrect keyid to be generated. This is because the call to `extract_pem` will strip any new line character from the public pem, which will then be used to generate the keyid, but this will be a different value than the keyid generated earlier due to the removal of the new line character. Signed-off-by: Daniel Bevenius <[email protected]>
|
this looks a lot like #453 just on a slightly higher level: I assume that one would likely fix the issue for you too? I'll also leave the same comment as in that pr: I would not trust the keyid generation to be stable and would instead generate a keyid once and then use that consistently in the application. |
Thanks for pointing that out, and yes I think that would solve this issue.
Ah I see, good to know that and I'll do that. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes being introduced by the pull request:
This commit adds a call to strip the public key pem value in
import_ecdsakey_from_private_pem.The motivation for this that a later call to
import_ecdsakey_from_public_pemwill otherwise cause an incorrectkeyidto be generated. This is because the call toextract_pemwill strip any new line character from the public pem, which will then be used to generate thekeyid, but this will be a different value than the keyid generated earlier due to the removal of the new line character.Please verify and check that the pull request fulfils the following requirements: