Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump colorama from 0.4.5 to 0.4.6 #441

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 25, 2022

Bumps colorama from 0.4.5 to 0.4.6.

Changelog

Sourced from colorama's changelog.

0.4.6 Current release

  • tartley/colorama#139 Add alternative to 'init()', called 'just_fix_windows_console'. This fixes many longstanding problems with 'init', such as working incorrectly on modern Windows terminals, and wonkiness when init gets called multiple times. The intention is that it just makes all Windows terminals treat ANSI the same way as other terminals do. Many thanks the njsmith for fixing our messes.
  • tartley/colorama#352 Support Windows 10's ANSI/VT console. This didn't exist when Colorama was created, and avoiding us causing havok there is long overdue. Thanks to segeviner for the initial approach, and to njsmith for getting it merged.
  • tartley/colorama#338 Internal overhaul of package metadata declaration, which abolishes our use of the now heavily discouraged setuptools (and hence setup.py, setup.cfg and MANIFEST.in), in favor of hatchling (and hence pyproject.toml), generously contributed by ofek (author of hatchling). This includes dropping support Python3.5 and 3.6, which are EOL, and were already dropped from setuptools, so this should not affect our users.
  • tartley/colorama#353 Attention to detail award to LqdBcnAtWork for a spelling fix in demo06
Commits
  • 3de9f01 bump version 0.4.6
  • a45949b Format the CHANGELOG bullet list, no content change
  • f55f72e comment need for a fix after recent MP broke it
  • cb83041 fix test-release after recent MPs broke it
  • 832f14c README tweaks
  • 54b89c3 Bump version to 0.4.6rc1
  • 7991d34 'make bootstrap' uses system python3, not pinned v3.8
  • 0ae5ef2 CHANGELOG updates for upcoming 0.4.6 release
  • 52f4cfd Tweak ordering of release checklist
  • ab64cfa Merge pull request #353 from LqdBcnAtWork/patch-1
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [colorama](https://github.com/tartley/colorama) from 0.4.5 to 0.4.6.
- [Release notes](https://github.com/tartley/colorama/releases)
- [Changelog](https://github.com/tartley/colorama/blob/master/CHANGELOG.rst)
- [Commits](tartley/colorama@0.4.5...0.4.6)

---
updated-dependencies:
- dependency-name: colorama
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Oct 25, 2022
@lukpueh
Copy link
Member

lukpueh commented Oct 25, 2022

Changelog LGTM and it is "only" an optional dependency, so I'm inclined to merge without more thorough review.

That said, I wonder if we really want to continue having colorama as dependency. cc @trishankatdatadog, who might remember the original motivation for adding the dependency.

@trishankatdatadog
Copy link
Contributor

That said, I wonder if we really want to continue having colorama as dependency. cc @trishankatdatadog, who might remember the original motivation for adding the dependency.

I think it was added on my request to colorise some text (especially role names), but we should remove this. Really, securesystemslib shouldn't have any prompts at all in the first place: it is a library, not an application.

@lukpueh
Copy link
Member

lukpueh commented Oct 26, 2022

This PR is obsoleted by #443

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 26, 2022

Looks like colorama is no longer a dependency, so this is no longer needed.

@dependabot dependabot bot closed this Oct 26, 2022
@dependabot dependabot bot deleted the dependabot/pip/colorama-0.4.6 branch October 26, 2022 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants