Minor changes #292
Merged
Minor changes #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have several unused modules, these were the obvious ones Signed-off-by: Joshua Lock <[email protected]>
Signed-off-by: Joshua Lock <[email protected]>
The hmac primitive was imported from pyca/cryptography and later shadowed by a local variable called hmac, requiring references to the pyca/cryptography primitive to be fully namespaced. Rename the local variable so that the import is no longer shadowed. Signed-off-by: Joshua Lock <[email protected]>
Signed-off-by: Joshua Lock <[email protected]>
Signed-off-by: Joshua Lock <[email protected]>
in-line with the rest of the module and coding style make changes to: * refer to the schema module by its bound name SCHEMA * not refer to methods from this module by their full namespace Signed-off-by: Joshua Lock <[email protected]>
trishankatdatadog
approved these changes
Oct 27, 2020
Merged
3 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: N/A
Description of the changes being introduced by the pull request:
A small series of minor, mostly cosmetic, changes that caught my eye while looking at the code with a view to change the way we're doing imports.
Please verify and check that the pull request fulfils the following requirements: