Add interface.export_pubkeys convenience function #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add package-wide constants for key types. NOTE: These values are still hard-coded in many places. We should switch to using these and probably other global constants in a separate PR.
Add convenience function to import multiple public keys of different key types from file into an sslib dict format at once, and tests. Note: Uses the new pseudo-standard docstring style suggested in secure-systems-lab/code-style-guidelines#20. All new interface functions should use that style (existing docstrings will be converted in separate PRs).
lukpueh
changed the title
1 similar comment
joshuagl
approved these changes
Sep 30, 2020
|
|
||
|
|
||
| # Global constants | ||
| # TODO: Replace hard-coded key types with these constants (and add more) |
There was a problem hiding this comment.
Would these constants be better suited to the keys module? Is it worth documenting how we're choosing where to put constants?
There was a problem hiding this comment.
IMO __init__ is a good default place for global constants. If we want to module-scope them, we should coordinate with #270.
|
Thanks for the quick review, @joshuagl! |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: # -
Related to in-toto/in-toto#80
Description of the changes being introduced by the pull request:
Add convenience function to import multiple public keys of different key types from file into an sslib dict format at once, and tests.
Note: Uses the new pseudo-standard docstring style suggested in secure-systems-lab/code-style-guidelines#20. All new interface functions should use that style (existing docstrings will be converted in separate PRs).
Note2: This PR also adds a few package-wide constants for key types, that are still hardcoded in many places. We should switch to using these and probably other global constants in a separate PR.
Please verify and check that the pull request fulfils the following requirements: