Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused helper and global from interface module #276

Merged
merged 2 commits into from
Sep 30, 2020
Merged

Remove unused helper and global from interface module #276

merged 2 commits into from
Sep 30, 2020

Conversation

lukpueh
Copy link
Member

@lukpueh lukpueh commented Sep 30, 2020

Related to #270

Description of the changes being introduced by the pull request:

  • Remove unused interface._prompt helper
  • Remove unused interface.SUPPORTED_KEY_TYPES global

Note: I checked that neither are used in tuf or in-toto.

Please verify and check that the pull request fulfils the following requirements:

  • The code follows the Code Style Guidelines
  • Tests have been added for the bug fix or new feature
  • Docs have been added for the bug fix or new feature

@lukpueh lukpueh requested a review from joshuagl September 30, 2020 08:48
@coveralls
Copy link

coveralls commented Sep 30, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.0005%) to 98.949% when pulling 9924f5c on lukpueh:rm-unused-interface into 94d83b9 on secure-systems-lab:master.

joshuagl
joshuagl approved these changes Sep 30, 2020
View reviewed changes
Copy link
Collaborator

@joshuagl joshuagl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌 thanks @lukpueh !

@lukpueh lukpueh merged commit 21ab71c into secure-systems-lab:master Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuagl joshuagl joshuagl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lukpueh @coveralls @joshuagl