Allow verifying signatures without gpg #214
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
| @@ -203,9 +203,6 @@ def test_gpg_cmds(self): | |||
| with self.assertRaises(securesystemslib.exceptions.UnsupportedLibraryError): | |||
| securesystemslib.gpg.functions.create_signature('bar') | |||
|
|
|||
| with self.assertRaises(securesystemslib.exceptions.UnsupportedLibraryError): | |||
There was a problem hiding this comment.
Would it make sense to say that we do not raise this exception (regression test)?
There was a problem hiding this comment.
AFAICT this would require running the securesystemslib.gpg.functions.verify_signature(None, 'f00', 'bar') function with correctly formatted arguments. I'm not really sure how that could be added but this is a great idea.
3 tasks
|
A comprehensive fix including regression testing is available in #215. |
|
Fixed in #215. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please fill in the fields below to submit a pull request. The more information
that is provided, the better.
Issue:
A regression was introduced with #206
Before that it was possible to verify keys even if
gpgwas missing in the used environment.gpg is not required for verifying but a safe-guard was added in the
verify_signaturemethod which now prevents that possibility.Description of the changes being introduced by the pull request:
Removes the safe-guard introduced in #206
Please verify and check that the pull request fulfils the following
requirements: