Make check_match() errors more readable for ListOf objects #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuagl
force-pushed
the
joshuagl/issue194
branch
from
31b9a2a to
b8cc8f9
Compare
lukpueh
reviewed
Jan 6, 2020
joshuagl
force-pushed
the
joshuagl/issue194
branch
from
b8cc8f9 to
cb2ae4e
Compare
|
Thanks for the incisive feedback. I've force-pushed an updated patch to address your two primary comments. As I understand it we can not switch to the new style string formatting until we drop Python 2 support, which I understood to be something we don't want to rush into. |
When the ListOf object's check_match() fails due to an incompatible object having been passed, the salient information for the error message is the type of the passed object and the type of the object against which the check_match() method was called, therefore print those types in the error message and not the string representation of the objects. Fixes secure-systems-lab#194 Signed-off-by: Joshua Lock <[email protected]>
joshuagl
force-pushed
the
joshuagl/issue194
branch
from
cb2ae4e to
81cf8fa
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please fill in the fields below to submit a pull request. The more information
that is provided, the better.
Fixes issue #194:
Description of the changes being introduced by the pull request:
When the ListOf object's check_match() fails due to an incompatible object
having been passed, the salient information for the error message is the
type of the passed object and the type of the object against which the
check_match() method was called, therefore print those types in the error
message and not the string representation of the objects.
Please verify and check that the pull request fulfills the following
requirements: