VaultSigner test unexpectedly does not depend on environment variables #888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicholasTanz
force-pushed
the
vaultsigner
branch
from
7feb97a to
d7ad9b5
Compare
…ting test server Signed-off-by: NicholasTanz <[email protected]> add vault_addr env to yaml Signed-off-by: NicholasTanz <[email protected]> change back to original setup Signed-off-by: NicholasTanz <[email protected]> specify address to listen to and use non-default port Signed-off-by: NicholasTanz <[email protected]>
NicholasTanz
force-pushed
the
vaultsigner
branch
from
504497d to
428ba35
Compare
|
Hi @jku, I'm running into an issue where the |
|
I have to admit I know very little about vault or the test setup here. @kairoaraujo might have more to say here? |
Added to my TODO. |
Signed-off-by: NicholasTanz <[email protected]>
Signed-off-by: NicholasTanz <[email protected]>
Signed-off-by: NicholasTanz <[email protected]>
Signed-off-by: NicholasTanz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes being introduced by the pull request:
Fixes: #820