Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ed25519 upstream has new commits #305

Closed
github-actions bot opened this issue Nov 24, 2020 · 2 comments · Fixed by #317
Closed

ed25519 upstream has new commits #305

github-actions bot opened this issue Nov 24, 2020 · 2 comments · Fixed by #317
Assignees
@jku

Comments

@github-actions
Copy link

It seems https://github.com/pyca/ed25519.git has new commits. Please review them, update the vendored copy if needed, and then update the expected hash in _vendor/test-ed25519-upstream.sh
@joshuagl
Copy link
Collaborator

The only change is to add a Dependabot configuration to check for updates to the GitHub Actions they are using in pyca/ed25519@0abd61b

I think it's safe to ignore this change.

@jku – how much effort do you think it would be to include the expected and found commit hashes, as reported by securesystemslib/_vendor/test-ed25519-upstream.sh, in the Issue filed by the check-upstream-ed25519 workflow? That would make it even easier to check whether the new commits are important.

@jku
Copy link
Collaborator

jku commented Jan 15, 2021

wow, I had completely missed this issue... It's not hard at all (of course including script output in the bug report might look wild if the script ever breaks but probably still better for debugging than current situation).

I'll take this.

@jku jku self-assigned this Jan 15, 2021
jku pushed a commit to jku/securesystemslib that referenced this issue Jan 15, 2021
ed25519: Update expected commit
ffc106c 
This change in ed25519 is an infrastructure change only: no need to
update.

Fixes secure-systems-lab#305
@jku jku mentioned this issue Jan 15, 2021
Merged
jku pushed a commit to jku/securesystemslib that referenced this issue Jan 15, 2021
ed25519: Update expected commit
cd841cd 
This change in ed25519 is an infrastructure change only: no need to
update.

Fixes secure-systems-lab#305
MVrachev pushed a commit to MVrachev/securesystemslib that referenced this issue Feb 16, 2021
@MVrachev
ed25519: Update expected commit
7ff8eba 
This change in ed25519 is an infrastructure change only: no need to
update.

Fixes secure-systems-lab#305
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jku jku

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Better ed25519 upstream reporting, update expected commit jku/securesystemslib
2 participants
@jku @joshuagl