Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export the EnvelopeVerifier type #12

Merged
merged 1 commit into from
Feb 25, 2022

Conversation

nmiyake
Copy link
Contributor

@nmiyake nmiyake commented Feb 25, 2022

Restore dsse.EnvelopVerifier as an external type as it was
in versions 0.1.0 and 0.2.0.

Fixes #11

Restore dsse.EnvelopVerifier as an external type as it was
in versions 0.1.0 and 0.2.0.

Fixes secure-systems-lab#11
@nmiyake
Copy link
Contributor Author

nmiyake commented Feb 25, 2022

@adityasaky would appreciate a review, merge, and release with this change if possible.

Without this change, we're unable to update our dependency of this module past version 0.2.0 because we have defined functions that use variables of type dsse.EnvelopeVerifier and it is no longer possible to do so because the type was made unexported in 0.3.0 (despite the fact that other exported functions still return values of this type).

@coveralls
Copy link

coveralls commented Feb 25, 2022

Pull Request Test Coverage Report for Build 1896392137

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.913%

Totals Coverage Status
Change from base Build 1549769616: 0.0%
Covered Lines: 216
Relevant Lines: 230

💛 - Coveralls

@adityasaky adityasaky merged commit e5b9b0e into secure-systems-lab:main Feb 25, 2022
@adityasaky
Copy link
Member

@nmiyake nmiyake deleted the exportEnvelopeVerifier branch February 25, 2022 20:29
@nmiyake
Copy link
Contributor Author

nmiyake commented Feb 25, 2022

Thank you, much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make EnvelopeVerifier an exported type
3 participants