Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup Build #673

Merged
merged 37 commits into from
Oct 27, 2023
Merged

Cleanup Build #673

merged 37 commits into from
Oct 27, 2023

Conversation

fabianbs96
Copy link
Member

PhASAR's CMakeLists are highly redundant making them sometimes hard to understand.
This PR is a collection of minor changes that aim to improve the cmake build scripts and the CI as well as other minor build-related issues.

@fabianbs96 fabianbs96 self-assigned this Oct 2, 2023
@fabianbs96 fabianbs96 marked this pull request as ready for review October 9, 2023 17:59
@fabianbs96 fabianbs96 requested a review from MMory as a code owner October 9, 2023 17:59
@fabianbs96 fabianbs96 requested a review from janniclas as a code owner October 12, 2023 15:34
Copy link
Member

@MMory MMory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@MMory MMory merged commit 9eda5e2 into development Oct 27, 2023
4 checks passed
@MMory MMory deleted the f-CleanupBuild branch October 27, 2023 12:52
@fabianbs96 fabianbs96 mentioned this pull request Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants