-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phasar DynLib and LTO #621
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be good to have a hint somewhere that makes people include their newly added header(s) to the directory include headers. Coding guidelines?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks!
@vulder does this break vara? just wanna make sure it doesn't before we merge, adding a block for this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From a comparability standpoint, this works for us.
PS: I did not fully check the rest of the PR, just if it works in our in-tree setup. 👍
PhASAR 's codebase is growing continuously which makes it harder for externals to keep an overview, e.g. which libraries should be linked against, which headers to include (and where to find them).
This PR adds convenience headers that include every header from a particular subdirectory (plus one that includes whole phasar).
Additionally, phasar now builds a large library
libphasar.a
/libphasar.so
by default that can be linked against.The smaller "component-wise" libraries are still there for a more optimized build.