Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ref-counted ModuleSlotTracker #614

Merged
merged 2 commits into from
May 4, 2023
Merged

Conversation

fabianbs96
Copy link
Member

Phasar currently crashes when the same llvm::Module is managed by multiple LLVMProjectIRDB instances at the same time. This situation occurrs for example when phasar is used in LLVM's pass infrastructure and multiple phasar-passes are run in one opt-call.

Reference-counting the cached ModuleSlotTracker instances fixes this problem.

@fabianbs96 fabianbs96 self-assigned this May 3, 2023
@fabianbs96 fabianbs96 requested a review from MMory as a code owner May 3, 2023 17:07
@fabianbs96 fabianbs96 added bug Something isn't working enhancement New feature or request labels May 3, 2023
Copy link
Member

@MMory MMory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@fabianbs96 fabianbs96 merged commit 88e42a2 into development May 4, 2023
@fabianbs96 fabianbs96 deleted the f-RefCountedModuleSlotTracker branch May 4, 2023 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants