Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Boost Installation #612

Merged
merged 2 commits into from
Apr 20, 2023
Merged

Fix Boost Installation #612

merged 2 commits into from
Apr 20, 2023

Conversation

fabianbs96
Copy link
Member

The BOOST_VERSION check inside bootstrap.sh returns exit code 1 if boost is not already installed preventing the script from continuing.

@fabianbs96 fabianbs96 self-assigned this Apr 19, 2023
@fabianbs96 fabianbs96 requested a review from MMory as a code owner April 19, 2023 18:05
@fabianbs96 fabianbs96 linked an issue Apr 19, 2023 that may be closed by this pull request
Bootstrap.sh not working with no boost library installed #611
Closed
7 tasks
@fabianbs96 fabianbs96 mentioned this pull request Apr 19, 2023
Closed
7 tasks
MMory
MMory approved these changes Apr 20, 2023
View reviewed changes
Copy link
Member

@MMory MMory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@MMory MMory merged commit 710ef66 into development Apr 20, 2023
@MMory MMory deleted the f-FixBoostInstallation branch April 20, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MMory MMory MMory approved these changes

Assignees

@fabianbs96 fabianbs96

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bootstrap.sh not working with no boost library installed
2 participants
@fabianbs96 @MMory