Fix global handling in type state analysis (#651)

* fix global handling in type state analysis * Fix error due to update from dev * fix killing of globals: only kill if no declaration-only func is called --------- Co-authored-by: Martin Mory <[email protected]> Co-authored-by: Fabian Schiebel <[email protected]>
secure-software-engineering · Nov 17, 2023 · 659cb8d · 659cb8d
1 parent 5ddab3f
commit 659cb8d
Showing 1 changed file with 7 additions and 0 deletions.
diff --git a/lib/PhasarLLVM/DataFlow/IfdsIde/Problems/IDETypeStateAnalysis.cpp b/lib/PhasarLLVM/DataFlow/IfdsIde/Problems/IDETypeStateAnalysis.cpp
@@ -182,13 +182,16 @@ auto IDETypeStateAnalysisBase::getCallToRetFlowFunction(
     n_t CallSite, n_t /*RetSite*/, llvm::ArrayRef<f_t> Callees)
     -> FlowFunctionPtrType {
   const auto *CS = llvm::cast<llvm::CallBase>(CallSite);
+  bool DeclarationOnlyCalleeFound = false;
   for (const auto *Callee : Callees) {
     std::string DemangledFname = llvm::demangle(Callee->getName().str());
     // Generate the return value of factory functions from zero value
     if (isFactoryFunction(DemangledFname)) {
       return this->generateFromZero(CS);
     }
 
+    DeclarationOnlyCalleeFound |= Callee->isDeclaration();
+
     /// XXX: Revisit this:
 
     // Handle all functions that are not modeld with special semantics.
@@ -209,6 +212,10 @@ auto IDETypeStateAnalysisBase::getCallToRetFlowFunction(
       }
     }
   }
+  if (!DeclarationOnlyCalleeFound) {
+    return killFlowIf(
+        [](d_t Source) { return llvm::isa<llvm::Constant>(Source); });
+  }
   return identityFlow();
 }