Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support TF 2.16 #858

Merged
merged 21 commits into from
Sep 9, 2024
Merged

Support TF 2.16 #858

merged 21 commits into from
Sep 9, 2024

Conversation

uri-granta
Copy link
Collaborator

@uri-granta uri-granta commented Jun 22, 2024

Related issue(s)/PRs:

Summary

Add support for Tensorflow 2.16.1. Since this uses Keras 3 as the default keras, I've had to switch all uses of tf.keras (including hidden ones like tf.optimizer) to gpflow's tf_keras version-agnostic shortcut.

I've also put a maximum supported TF version, to prevent people trying to install trieste with unsupported versions in the future (since TF minor versions are offten not backwards compatible).

And I've removed support for Python 3.7 (which is already end-of-life) and 3.8 (which ends of life in less than a month) and switched the minimum supported version to 3.9.

Fully backwards compatible: yes

PR checklist

  • The quality checks are all passing
  • The bug case / new feature is covered by tests
  • Any new features are well-documented (in docstrings or notebooks)

@uri-granta uri-granta marked this pull request as ready for review September 6, 2024 15:33
Copy link
Collaborator

@khurram-ghani khurram-ghani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. (Had a quick chat offline).

@uri-granta uri-granta merged commit 9e5cdb1 into develop Sep 9, 2024
12 checks passed
@uri-granta uri-granta deleted the uri/support_tf_2_16 branch September 9, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants