Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add state handling to filter_datasets #841

Merged
merged 22 commits into from
May 28, 2024

Conversation

uri-granta
Copy link
Collaborator

Related issue(s)/PRs:

Summary

...

Fully backwards compatible: yes / no

PR checklist

  • The quality checks are all passing
  • The bug case / new feature is covered by tests
  • Any new features are well-documented (in docstrings or notebooks)

@uri-granta uri-granta requested a review from khurram-ghani May 15, 2024 08:53
@uri-granta uri-granta marked this pull request as ready for review May 15, 2024 08:53
@uri-granta uri-granta changed the title Try adding state handling to filter_datasets Add state handling to filter_datasets May 15, 2024
tests/unit/acquisition/test_rule.py Show resolved Hide resolved
trieste/acquisition/rule.py Outdated Show resolved Hide resolved
trieste/acquisition/rule.py Show resolved Hide resolved
@uri-granta uri-granta requested a review from khurram-ghani May 24, 2024 13:06
@uri-granta uri-granta requested a review from khurram-ghani May 24, 2024 19:08
@uri-granta uri-granta merged commit 452b7e2 into develop May 28, 2024
12 checks passed
@uri-granta uri-granta deleted the uri/filter_datasets_state_handling branch May 28, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants