Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test against Python 3.10 #688

Merged
merged 3 commits into from
Feb 1, 2023
Merged

Test against Python 3.10 #688

merged 3 commits into from
Feb 1, 2023

Conversation

uri-granta
Copy link
Collaborator

Migrate *_latest tests from Python 3.9 to Python 3.10. Keep the 3.7 tests as before.

sc336
sc336 approved these changes Feb 1, 2023
View reviewed changes
Copy link
Collaborator

@sc336 sc336 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Feel free to leave a comment about moving from 3.7 to "3.7" throughout if you like, but I doubt it's important.

@uri-granta
Copy link
Collaborator Author

LGTM. Feel free to leave a comment about moving from 3.7 to "3.7" throughout if you like, but I doubt it's important.

(That's because versions aren't numbers, which isn't a problem for 3.9 but is for 3.10, which as a number gets converted to 3.1)

@uri-granta uri-granta merged commit 3f688e3 into develop Feb 1, 2023
@uri-granta uri-granta deleted the uri/test_against_python_3_10 branch February 1, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sc336 sc336 sc336 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uri-granta @sc336