Fix remaining numpy mypy issues #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hstojic
reviewed
Feb 28, 2022
tests/unit/acquisition/test_utils.py
Outdated
| @@ -41,7 +42,7 @@ | |||
| ], | |||
| ) | |||
| def test_split_acquisition_function( | |||
| f: AcquisitionFunction, x: np.ndarray, split_size: int, expected_batches: int | |||
| f: AcquisitionFunction, x: np.ndarray[Any, Any], split_size: int, expected_batches: int | |||
There was a problem hiding this comment.
so here we explicitly state the type of objects in arrays, similar as with tuple, List etc?
There was a problem hiding this comment.
Yes: the parameters refer to shape and dtype (though shape isn't properly supported at the moment, and we currently don't handle dtypes well enough to use that part). There's a cleaner shorthand in numpy.typing called npt.NDArray but that doens't work with older versions of numpy.
hstojic
reviewed
Feb 28, 2022
| # pytest uses yield in a funny way, so we use type ignore | ||
| @pytest.fixture(name="keras_float") # type: ignore | ||
| def _keras_float() -> None: | ||
| @pytest.fixture(name="keras_float") |
There was a problem hiding this comment.
should we then move this fixture up to tests/conftest.py since we have it now in multiple places?
There was a problem hiding this comment.
👍 but planning to tidy up the conftests in a separate PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the remaining issues exposed by the numpy stubs introduce in 1.21 and adds a workflow to test this.