Test with Python 3.9 and TF 2.5 #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uri-granta
changed the title
hstojic
reviewed
Feb 7, 2022
| @@ -24,29 +24,36 @@ extend-exclude = docs/notebooks/,.venv | |||
|
|
|||
| [testenv] | |||
| basepython = python3.7 | |||
| deps = pip~=20.3 | |||
| deps = pip | |||
There was a problem hiding this comment.
will this potentially mean an old pip version will be used?
There was a problem hiding this comment.
This should use the latest version (which we were explicitly doing anyway in most of the commands via a pip install).
hstojic
reviewed
Feb 7, 2022
| types: pip install -r common_build/types/requirements.txt -c common_build/types/constraints.txt | ||
| types: mypy | ||
| types: mypy {posargs} |
There was a problem hiding this comment.
where from are these {posargs} coming from?
There was a problem hiding this comment.
They're passed in on the command line. Hence to run the slow tests we can now run "tox -e tests -- --runslow yes" instead of having a whole different tox job. This also lets you run just one test or type check just one file if you want to.
hstojic
approved these changes
Feb 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.