Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE remove master branch #22

Merged
merged 1 commit into from
Oct 27, 2020
Merged

DO NOT MERGE remove master branch #22

merged 1 commit into from
Oct 27, 2020

Conversation

joelberkeley
Copy link
Contributor

@joelberkeley joelberkeley commented Oct 17, 2020

DO NOT MERGE without asking. There are external changes that need to happen at the same time as this being merged.

the master branch is superfluous. This PR does the code prep needed to remove it. Instead of building the docs on pushes to master (which, incidentally, is fragile to people pushing to master outside of releases), this PR proposes we build the docs when a semver-compliant tag is pushed. If a tag is pushed by mistake, thus building the docs for the wrong point in the code, we can delete and redeploy the latest correct tag (taking care with associated github releases)

We'll also need to

  • delete the master branch
  • check the github releases are still in place
  • remove the master branch protection rules
  • probably mention in slack #trieste so that people aren't confused

@joelberkeley joelberkeley changed the title remove master branch DO NOT MERGE remove master branch Oct 18, 2020
@joelberkeley joelberkeley marked this pull request as ready for review October 26, 2020 19:18
@ChrisMorter ChrisMorter self-requested a review October 27, 2020 13:20
Copy link
Collaborator

@ChrisMorter ChrisMorter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joelberkeley joelberkeley merged commit a5113df into secondmind-labs:develop Oct 27, 2020
@joelberkeley joelberkeley deleted the joelb/remove-master branch October 27, 2020 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants