Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DNS-SD command #4481

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Add DNS-SD command #4481

merged 1 commit into from
Jul 30, 2024

Conversation

gpotter2
Copy link
Member

@gpotter2 gpotter2 commented Jul 29, 2024

This PR:

  • adds a verry simple dnssd() command to perform mDNS service discoveries. I like it
  • By default it performs a rfc6763 type-enumeration (section 9), but you can also try services like _spotify-connect._tcp.local, etc. the .show() command then tries to summarize the results

Note:

meaning this sadly probably won't get merged before 2.6

Copy link

codecov bot commented Jul 29, 2024

Codecov Report

Attention: Patch coverage is 20.45455% with 35 lines in your changes missing coverage. Please review.

Project coverage is 81.65%. Comparing base (9738e4a) to head (82a07b4).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4481      +/-   ##
==========================================
- Coverage   81.68%   81.65%   -0.03%     
==========================================
  Files         355      355              
  Lines       84702    84745      +43     
==========================================
+ Hits        69186    69197      +11     
- Misses      15516    15548      +32     
Files Coverage Δ
scapy/layers/dns.py 83.99% <20.45%> (-3.69%) ⬇️

... and 5 files with indirect coverage changes

@gpotter2 gpotter2 merged commit 18b3d6c into secdev:master Jul 30, 2024
24 checks passed
@gpotter2 gpotter2 deleted the dnssd branch July 30, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant