Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: run scapy on aarch64, i386, ppc64le, s390x and x86_64 on PRs #4355

Merged
merged 1 commit into from
Apr 20, 2024

Conversation

evverx
Copy link
Contributor

@evverx evverx commented Apr 20, 2024

The script takes the Fedora package, edits the spec file to make it compatible with the upstream test suite and then it's all run on all those architectures on the latest stable Fedora release and Fedora Rawhide. (Rawhide is kind of a testing relase but it's useful in terms of catching things like #4280 reproducible with relatively new packages only).

It was originally prompted by
#3847 (where the Debian autopkgtest was run on big-endian and 32-bit machines) and should hopefully make it easier to catch various issues before they land.

It has been tested since the beginning of 2023 so it should be stable at this point.

To get it to work the repository should be hooked up to Packit: https://packit.dev/docs/guide#github.

(If there are any issues it should be possible to contact the Packit folks directly: evverx#1 (comment))

The script takes the Fedora package, edits the spec file to make it
compatible with the upstream test suite and then it's all run on all
those architectures on the latest stable Fedora release and Fedora
Rawhide. (Rawhide is kind of a testing relase but it's useful in terms of
catching things like secdev#4280
reproducible with relatively new packages only).

It was originally prompted by
secdev#3847 (where the Debian
autopkgtest was run on big-endian and 32-bit machines) and should
hopefully make it easier to catch various issues before they land.

It has been tested since the beginning of 2023 so it should be stable at
this point.
Copy link

codecov bot commented Apr 20, 2024

Codecov Report

Merging #4355 (e39aafb) into master (1302042) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4355      +/-   ##
==========================================
- Coverage   82.13%   82.13%   -0.01%     
==========================================
  Files         350      350              
  Lines       83136    83136              
==========================================
- Hits        68284    68281       -3     
- Misses      14852    14855       +3     

see 5 files with indirect coverage changes

@evverx evverx mentioned this pull request Apr 20, 2024
Copy link
Member

@gpotter2 gpotter2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR !

@gpotter2 gpotter2 merged commit 86c7a05 into secdev:master Apr 20, 2024
23 checks passed
@gpotter2
Copy link
Member

This is working great BTW, thanks again.

I've ended up enabling the manual trigger, so one has to do a <SLASH> packit build to run it. I didn't want to abuse the packit infra, and we probably don't need to test those plateforms after every commit.

@evverx
Copy link
Contributor Author

evverx commented Apr 21, 2024

one has to do a packit build to run it

Makes sense. Though it isn't always obvious how PRs can affect it. For example I cherry-picked #4351 on top of my fork, removed -K manufdb, triggered Packit and it failed there even though the GH Actions are green: https://download.copr.fedorainfracloud.org/results/packit/evverx-scapy-2/fedora-rawhide-x86_64/07331856-scapy/builder-live.log.gz. I think it should be safe to trigger it before PRs are merged just in case.

In the meantime I'll send another PR to turn on the "netaccess" tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants