Improve Bluetooth HCI Command packet definition #4088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4088 +/- ##
==========================================
+ Coverage 81.95% 81.97% +0.01%
==========================================
Files 328 328
Lines 75852 75897 +45
==========================================
+ Hits 62163 62213 +50
+ Misses 13689 13684 -5
|
gpotter2
reviewed
Aug 8, 2023
benquike
force-pushed
the
master
branch
2 times, most recently
from
8942fbf
to
4a48d02
Compare
- Divide opcode into ogf and ocf following Core Spec - Redefine existing HCI commands with new format
|
You have quite a bunch of failing tests. Could you fix those? Thanks |
|
Please do not run an auto-formatter. This brings many un-necessary changes to the PR making it harder to review, and breaking the history. Could you revert this commit and only fix the formatting of your own changes? Thanks |
1. Fix some outdated command definitions 2. Fix the names of commands, use the formal name from core spec 3. Fix the some of the tests
|
@gpotter2 Can you please have another look? |
gpotter2
approved these changes
Aug 25, 2023
|
Thanks for the PR ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
cd test && ./run_testsortox)The ogf and ocf fields in the Bluetooth HCI Command Header are grouped together,
making it difficult to check these individual fields and mapping them back to packet definitions in
Core spec.
This change divide the opcode field into ogf and ocf bitfields following the defitions in core spec.