Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add layer HICP #4075

Merged
merged 2 commits into from
Jul 26, 2023
Merged

Add layer HICP #4075

merged 2 commits into from
Jul 26, 2023

Conversation

claire-lex
Copy link
Contributor

Checklist:

  • If you are new to Scapy: I have checked CONTRIBUTING.md (esp. section submitting-pull-requests)
  • I squashed commits belonging together
  • I added unit tests or explained why they are not relevant
  • I executed the regression tests (using cd test && ./run_tests or tox)
  • If the PR is still not finished, please create a Draft Pull Request

This PR adds support for a new protocol in contrib: HICP
The protocol is used by industrial devices HMS Anybus for network discovery and configuration.
All the messages used by the official HMS IPconfig software are implemented.

@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Merging #4075 (f6dd968) into master (7d31fcc) will increase coverage by 0.02%.
The diff coverage is 89.86%.

@@            Coverage Diff             @@
##           master    #4075      +/-   ##
==========================================
+ Coverage   81.95%   81.98%   +0.02%     
==========================================
  Files         327      328       +1     
  Lines       75568    75766     +198     
==========================================
+ Hits        61935    62113     +178     
- Misses      13633    13653      +20     
Files Changed Coverage Δ
scapy/contrib/hicp.py 89.86% <89.86%> (ø)

... and 19 files with indirect coverage changes

Copy link
Member

@gpotter2 gpotter2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR ! It looks solid.

Minor nit found by the CI.

Scapy's support for text-based protocols is subpar, so congrats on making that work !

scapy/contrib/hicp.py Outdated Show resolved Hide resolved
@gpotter2 gpotter2 merged commit 204605b into secdev:master Jul 26, 2023
19 checks passed
@gpotter2 gpotter2 added this to the 2.6.0 milestone Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants