Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for CanFD in the ISOTPSoftSocket #4048

Merged
merged 6 commits into from
Sep 11, 2023
Merged

Added support for CanFD in the ISOTPSoftSocket #4048

merged 6 commits into from
Sep 11, 2023

Conversation

polybassa
Copy link
Contributor

Rebased #3967

@codecov
Copy link

codecov bot commented Jun 27, 2023 •
edited
Loading

Codecov Report

Merging #4048 (ea1bf48) into master (b1fa811) will decrease coverage by 0.01%.
The diff coverage is 94.44%.

@@            Coverage Diff             @@
##           master    #4048      +/-   ##
==========================================
- Coverage   81.96%   81.95%   -0.01%     
==========================================
  Files         327      327              
  Lines       75614    75640      +26     
==========================================
+ Hits        61978    61994      +16     
- Misses      13636    13646      +10
Impacted Files Coverage Δ
scapy/contrib/isotp/isotp_soft_socket.py 85.11% <93.10%> (+0.27%) ⬆️
scapy/contrib/isotp/isotp_packet.py 93.29% <100.00%> (+0.10%) ⬆️

... and 7 files with indirect coverage changes

@polybassa polybassa mentioned this pull request Jul 10, 2023
Closed
gpotter2
gpotter2 requested changes Jul 14, 2023
View reviewed changes
test/contrib/isotp_soft_socket_fd.uts Outdated Show resolved Hide resolved
@polybassa polybassa force-pushed the eHonnef/isotp-soft-socket-can-fd-support branch from a2be092 to ea1bf48 Compare July 22, 2023 19:11
@polybassa
Copy link
Contributor Author

@gpotter2 This is ready for merge

@polybassa
Copy link
Contributor Author

@guedou @p-l- Can this PR please get merged?

gpotter2
gpotter2 approved these changes Sep 11, 2023
View reviewed changes
Copy link
Member

@gpotter2 gpotter2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, LGTM.

@gpotter2 gpotter2 merged commit 4c62008 into secdev:master Sep 11, 2023
19 checks passed
@gpotter2 gpotter2 added this to the 2.6.0 milestone Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpotter2 gpotter2 gpotter2 approved these changes

Assignees
No one assigned
Labels
needs rework/cleanup
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@polybassa @gpotter2 @eHonnef